Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Side by Side Diff: runtime/observatory/tests/observatory_ui/ports/element_test.dart

Issue 2995923002: Restore "Speedup Observatory elements first time rendering" (Closed)
Patch Set: Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « runtime/observatory/tests/observatory_ui/observatory_ui.status ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2016, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2016, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 import 'dart:html'; 5 import 'dart:html';
6 import 'package:unittest/unittest.dart'; 6 import 'package:unittest/unittest.dart';
7 import 'package:observatory/src/elements/ports.dart'; 7 import 'package:observatory/src/elements/ports.dart';
8 import '../mocks.dart'; 8 import '../mocks.dart';
9 9
10 main() { 10 main() {
(...skipping 21 matching lines...) Expand all
32 final ports = new PortsRepositoryMock( 32 final ports = new PortsRepositoryMock(
33 getter: expectAsync((i) async { 33 getter: expectAsync((i) async {
34 expect(i, equals(isolate)); 34 expect(i, equals(isolate));
35 return isolatePorts; 35 return isolatePorts;
36 }, count: 1)); 36 }, count: 1));
37 final objects = new ObjectRepositoryMock(); 37 final objects = new ObjectRepositoryMock();
38 final e = new PortsElement(vm, isolate, events, notifs, ports, objects); 38 final e = new PortsElement(vm, isolate, events, notifs, ports, objects);
39 document.body.append(e); 39 document.body.append(e);
40 await e.onRendered.first; 40 await e.onRendered.first;
41 expect(e.children.length, isNonZero, reason: 'has elements'); 41 expect(e.children.length, isNonZero, reason: 'has elements');
42 await e.onRendered.first;
42 expect(e.querySelectorAll('.port-number').length, equals(elements.length)); 43 expect(e.querySelectorAll('.port-number').length, equals(elements.length));
43 e.remove(); 44 e.remove();
44 await e.onRendered.first; 45 await e.onRendered.first;
45 expect(e.children.length, isZero, reason: 'is empty'); 46 expect(e.children.length, isZero, reason: 'is empty');
46 }); 47 });
47 } 48 }
OLDNEW
« no previous file with comments | « runtime/observatory/tests/observatory_ui/observatory_ui.status ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698