Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Unified Diff: runtime/observatory/lib/src/elements/retaining_path.dart

Issue 2995923002: Restore "Speedup Observatory elements first time rendering" (Closed)
Patch Set: Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/observatory/lib/src/elements/retaining_path.dart
diff --git a/runtime/observatory/lib/src/elements/retaining_path.dart b/runtime/observatory/lib/src/elements/retaining_path.dart
index d82b9f8e9227135922ba9b47ff7db492e5727df0..84df2d816c58abeadd1995cdb2201c8089ac4e2a 100644
--- a/runtime/observatory/lib/src/elements/retaining_path.dart
+++ b/runtime/observatory/lib/src/elements/retaining_path.dart
@@ -61,18 +61,19 @@ class RetainingPathElement extends HtmlElement implements Renderable {
}
void render() {
- children = [
- new CurlyBlockElement(expanded: _expanded, queue: _r.queue)
- ..content = _createContent()
- ..onToggle.listen((e) async {
- _expanded = e.control.expanded;
- if (_expanded) {
- e.control.disabled = true;
- await _refresh();
- e.control.disabled = false;
- }
- })
- ];
+ final curlyBlock =
+ new CurlyBlockElement(expanded: _expanded, queue: _r.queue)
+ ..content = _createContent()
+ ..onToggle.listen((e) async {
+ _expanded = e.control.expanded;
+ if (_expanded) {
+ e.control.disabled = true;
+ await _refresh();
+ e.control.disabled = false;
+ }
+ });
+ children = [curlyBlock];
+ _r.waitFor([curlyBlock.onRendered.first]);
}
Future _refresh() async {

Powered by Google App Engine
This is Rietveld 408576698