Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 2997223002: Add screenshots of diagnostics to metrics-results-ui.md. (Closed)

Created:
3 years, 4 months ago by benjhayden
Modified:
3 years, 4 months ago
Reviewers:
eakuefner
CC:
catapult-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Add screenshots of diagnostics to metrics-results-ui.md. Screenshots of diagnostics are already in how-to-write-metrics, but these UI components should also be documented in metrics-results-ui. BUG=catapult:#3609 Review-Url: https://codereview.chromium.org/2997223002 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/85ae8132f3cd790bb9e77f2172f28931ac7e27dd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -1 line) Patch
A docs/images/metrics-results-ui-diagnostics-tabs.png View Binary file 0 comments Download
M docs/metrics-results-ui.md View 2 chunks +31 lines, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
benjhayden
PTAL
3 years, 4 months ago (2017-08-18 08:01:59 UTC) #2
eakuefner
lgtm
3 years, 4 months ago (2017-08-18 23:24:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2997223002/1
3 years, 4 months ago (2017-08-20 17:55:05 UTC) #5
commit-bot: I haz the power
3 years, 4 months ago (2017-08-20 18:28:20 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698