|
Remove RelatedHistogramSet.
RelatedHistogramSet was designed as a way for metrics to say "all of these
histograms are related to this parent histogram, but the relationship between
the parent and each child is not meaningful". Experience with a few metrics and
further thought has shown that all relationships worth annotating are
meaningful, and deserved to be named via keys in RelatedHistogramMap/Breakdown.
RelatedHistogramSet is currently only used as an implementation detail
(MERGED_FROM, MERGED_TO) to facilitate merging RelatedHistogramSet/Maps and
filtering the histogram-set-table. This usage is replaced with
RelatedHistogramMap using counters for keys.
BUG=catapult:#3661
Review-Url: https://codereview.chromium.org/2998043002
Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/1353a5dcce233fede2cb172b32aa67bc1063bec7
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+55 lines, -505 lines) |
Patch |
|
M |
docs/histogram-set-json-format.md
|
View
|
|
2 chunks |
+0 lines, -8 lines |
0 comments
|
Download
|
|
M |
docs/how-to-write-metrics.md
|
View
|
|
2 chunks |
+9 lines, -16 lines |
0 comments
|
Download
|
|
M |
tracing/trace_viewer.gypi
|
View
|
|
2 chunks |
+0 lines, -2 lines |
0 comments
|
Download
|
|
M |
tracing/tracing/value/diagnostics/add_related_names.html
|
View
|
|
1 chunk |
+0 lines, -5 lines |
0 comments
|
Download
|
|
M |
tracing/tracing/value/diagnostics/all_diagnostics.html
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
|
M |
tracing/tracing/value/diagnostics/diagnostic_map.html
|
View
|
|
1 chunk |
+4 lines, -5 lines |
0 comments
|
Download
|
|
M |
tracing/tracing/value/diagnostics/diagnostic_map_test.html
|
View
|
|
9 chunks |
+5 lines, -14 lines |
0 comments
|
Download
|
|
M |
tracing/tracing/value/diagnostics/related_histogram_map.html
|
View
|
|
2 chunks |
+3 lines, -3 lines |
0 comments
|
Download
|
|
D |
tracing/tracing/value/diagnostics/related_histogram_set.html
|
View
|
|
1 chunk |
+0 lines, -160 lines |
0 comments
|
Download
|
|
M |
tracing/tracing/value/diagnostics/reserved_infos.py
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
tracing/tracing/value/diagnostics/reserved_names.html
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
tracing/tracing/value/diagnostics/unmergeable_diagnostic_set.html
|
View
|
|
1 chunk |
+1 line, -2 lines |
0 comments
|
Download
|
|
M |
tracing/tracing/value/histogram.html
|
View
|
|
1 chunk |
+4 lines, -4 lines |
0 comments
|
Download
|
|
M |
tracing/tracing/value/histogram.py
|
View
|
|
3 chunks |
+2 lines, -47 lines |
0 comments
|
Download
|
|
M |
tracing/tracing/value/histogram_set.html
|
View
|
|
3 chunks |
+5 lines, -10 lines |
0 comments
|
Download
|
|
M |
tracing/tracing/value/histogram_set.py
|
View
|
|
1 chunk |
+1 line, -3 lines |
0 comments
|
Download
|
|
M |
tracing/tracing/value/histogram_set_hierarchy.html
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
tracing/tracing/value/histogram_set_test.html
|
View
|
|
2 chunks |
+3 lines, -64 lines |
0 comments
|
Download
|
|
M |
tracing/tracing/value/histogram_set_unittest.py
|
View
|
|
1 chunk |
+0 lines, -53 lines |
0 comments
|
Download
|
|
M |
tracing/tracing/value/histogram_unittest.py
|
View
|
|
3 chunks |
+5 lines, -6 lines |
0 comments
|
Download
|
|
M |
tracing/tracing/value/ui/diagnostic_span.html
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
|
M |
tracing/tracing/value/ui/histogram_set_table_test.html
|
View
|
|
2 chunks |
+6 lines, -2 lines |
0 comments
|
Download
|
|
D |
tracing/tracing/value/ui/related_histogram_set_span.html
|
View
|
|
1 chunk |
+0 lines, -53 lines |
0 comments
|
Download
|
|
D |
tracing/tracing/value/ui/related_histogram_set_span_test.html
|
View
|
|
1 chunk |
+0 lines, -37 lines |
0 comments
|
Download
|
|
M |
tracing/tracing/value/ui/unmergeable_diagnostic_set_span_test.html
|
View
|
|
1 chunk |
+1 line, -3 lines |
0 comments
|
Download
|
Total messages: 9 (5 generated)
|