Added static warning on assignment to final locals; adjusted for-in.

Added static warning on assignment to final locals; adjusted for-in.

Addresses spec omission which was brought up in SDK issue #30483.

The following issue was created specifically on this topic: #30489.

R=lrn@google.com

Committed: https://github.com/dart-lang/sdk/commit/6ef388db9dc8f1a03187b56f0324697744e71aa3

[eernst, 2017-08-18 15:26:00]

eernst@google.com changed reviewers:
+ lrn@google.com

[eernst, 2017-08-18 15:26:01]

Might as well fix this immediately in the spec: Nobody seems to think that it
_shouldn't_ be a static warning (2: error) to assign to a final local. Included
clarification of for-in.

[eernst, 2017-08-18 16:02:41]

Description was changed from

==========
Added static warning on assignment to final locals; adjusted for-in.

Addresses spec omission which was brought up in SDK issue #30483.
==========

to

==========
Added static warning on assignment to final locals; adjusted for-in.

Addresses spec omission which was brought up in SDK issue #30483.

The following issue was created specifically on this topic: #30489.
==========

[Lasse Reichstein Nielsen, 2017-08-18 19:11:58]

lgtm

https://codereview.chromium.org/2998073002/diff/60001/docs/language/dartLangS...
File docs/language/dartLangSpec.tex (right):

https://codereview.chromium.org/2998073002/diff/60001/docs/language/dartLangS...
docs/language/dartLangSpec.tex:5947: A for statement of the form \code{\FOR{}
($D$ $id$ \IN{} $e$) $s$} is equivalent to the following code:
THANK you! That "pattern syntax in concrete code" category error deserved to be
fixed!

https://codereview.chromium.org/2998073002/diff/60001/docs/language/dartLangS...
docs/language/dartLangSpec.tex:5962: It follows that it is a static warning if
$D$ is omitted and $id$ is a final variable,
D is omitted -> D is empty
(maybe?)

[eernst, 2017-08-21 07:29:20]

Description was changed from

==========
Added static warning on assignment to final locals; adjusted for-in.

Addresses spec omission which was brought up in SDK issue #30483.

The following issue was created specifically on this topic: #30489.
==========

to

==========
Added static warning on assignment to final locals; adjusted for-in.

Addresses spec omission which was brought up in SDK issue #30483.

The following issue was created specifically on this topic: #30489.

R=lrn@google.com

Committed:
https://github.com/dart-lang/sdk/commit/6ef388db9dc8f1a03187b56f0324697744e71aa3
==========

[eernst, 2017-08-21 07:29:21]

Committed patchset #5 (id:80001) manually as
6ef388db9dc8f1a03187b56f0324697744e71aa3 (presubmit successful).

[eernst, 2017-08-21 14:20:44]

Forgot to send review response before committing --- here we go.

https://codereview.chromium.org/2998073002/diff/60001/docs/language/dartLangS...
File docs/language/dartLangSpec.tex (right):

https://codereview.chromium.org/2998073002/diff/60001/docs/language/dartLangS...
docs/language/dartLangSpec.tex:5947: A for statement of the form \code{\FOR{}
($D$ $id$ \IN{} $e$) $s$} is equivalent to the following code:
On 2017/08/18 19:11:58, Lasse Reichstein Nielsen wrote:
> THANK you! That "pattern syntax in concrete code" category error deserved to
be
> fixed!

Acknowledged. ;-)

https://codereview.chromium.org/2998073002/diff/60001/docs/language/dartLangS...
docs/language/dartLangSpec.tex:5962: It follows that it is a static warning if
$D$ is omitted and $id$ is a final variable,
On 2017/08/18 19:11:58, Lasse Reichstein Nielsen wrote:
> D is omitted -> D is empty
> (maybe?)

I thought about that, too. Switched to `empty`, which seems better today.