Make timeout_retry include the total timeout in the exception error

Make timeout_retry include the total timeout in the exception error

Without the total timeout, it makes it sound like the polling period
is the total timeout.

BUG=catapult:#3776

Review-Url: https://chromiumcodereview.appspot.com/3000973002
Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/68ce41b9bda29bde7955f8655429b825cf89ab2b

[charliea (OOO until 10-5), 2017-08-15 18:25:33]

charliea@chromium.org changed reviewers:
+ jbudorick@chromium.org, perezju@chromium.org

[perezju, 2017-08-16 08:35:30]

https://codereview.chromium.org/3000973002/diff/1/devil/devil/utils/timeout_r...
File devil/devil/utils/timeout_retry.py (right):

https://codereview.chromium.org/3000973002/diff/1/devil/devil/utils/timeout_r...
devil/devil/utils/timeout_retry.py:55: % (required, remaining))
As I just wrote on the tracking issue; maybe it's fine to remove this extra
detail?

https://codereview.chromium.org/3000973002/diff/1/devil/devil/utils/timeout_r...
devil/devil/utils/timeout_retry.py:113: msg='Timed out waiting for %r' %
condition_name)
I think you also need to update the msg here to have an effect on the particular
log line you were looking at.

[charliea (OOO until 10-5), 2017-08-18 18:52:18]

PTAL

https://codereview.chromium.org/3000973002/diff/1/devil/devil/utils/timeout_r...
File devil/devil/utils/timeout_retry.py (right):

https://codereview.chromium.org/3000973002/diff/1/devil/devil/utils/timeout_r...
devil/devil/utils/timeout_retry.py:55: % (required, remaining))
On 2017/08/16 08:35:29, perezju wrote:
> As I just wrote on the tracking issue; maybe it's fine to remove this extra
> detail?

Done.

https://codereview.chromium.org/3000973002/diff/1/devil/devil/utils/timeout_r...
devil/devil/utils/timeout_retry.py:113: msg='Timed out waiting for %r' %
condition_name)
On 2017/08/16 08:35:29, perezju wrote:
> I think you also need to update the msg here to have an effect on the
particular
> log line you were looking at.

Given that I think that the caller is more likely to want to customize the
suffix than the base message, I changed the "msg" parameter to a "suffix"
parameter. This appears to be the only caller of that function that uses the msg
parameter.

[perezju, 2017-08-21 08:22:10]

lgtm

https://codereview.chromium.org/3000973002/diff/20001/devil/devil/utils/timeo...
File devil/devil/utils/timeout_retry.py (right):

https://codereview.chromium.org/3000973002/diff/20001/devil/devil/utils/timeo...
devil/devil/utils/timeout_retry.py:111: suffix=' (waiting for condition %r)' %
condition_name)
nit: maybe drop the parentheses.

[charliea (OOO until 10-5), 2017-09-21 18:16:50]

The CQ bit was checked by charliea@chromium.org

[charliea (OOO until 10-5), 2017-09-21 18:16:50]

The patchset sent to the CQ was uploaded after l-g-t-m from perezju@chromium.org
Link to the patchset: https://codereview.chromium.org/3000973002/#ps40001
(title: " ")

[commit-bot: I haz the power, 2017-09-21 18:17:02]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-09-21 18:49:18]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1506017810146230,
"parent_rev": "e1aa3179fac3ded8df9856820f270694572a10d3", "commit_rev":
"68ce41b9bda29bde7955f8655429b825cf89ab2b"}

[commit-bot: I haz the power, 2017-09-21 18:49:23]

Description was changed from

==========
Make timeout_retry include the total timeout in the exception error

Without the total timeout, it makes it sound like the polling period
is the total timeout.

BUG=catapult:#3776
==========

to

==========
Make timeout_retry include the total timeout in the exception error

Without the total timeout, it makes it sound like the polling period
is the total timeout.

BUG=catapult:#3776

Review-Url: https://chromiumcodereview.appspot.com/3000973002
Committed:
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...
==========

[commit-bot: I haz the power, 2017-09-21 18:49:23]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...