Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(702)

Unified Diff: runtime/observatory/lib/src/app/page.dart

Issue 3002843002: Introduce heap snapshot into Memory Dashboard (Closed)
Patch Set: Address CL comments Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/observatory/lib/src/elements/css/shared.css » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/observatory/lib/src/app/page.dart
diff --git a/runtime/observatory/lib/src/app/page.dart b/runtime/observatory/lib/src/app/page.dart
index eb35b84097959bbf58c1fe2c1b9dc7a17a40fa60..a873dc1414cb4cd06c2522d058e2d858c967fcc4 100644
--- a/runtime/observatory/lib/src/app/page.dart
+++ b/runtime/observatory/lib/src/app/page.dart
@@ -709,8 +709,16 @@ class MemoryDashboardPage extends MatchingPage {
// Preload all isolates to avoid sorting problems.
await Future.wait(vm.isolates.map((i) => i.load()));
container.children = [
- new MemoryDashboardElement(vm, _vmrepository, new IsolateRepository(vm),
- editor, _allocationProfileRepository, app.events, app.notifications,
+ new MemoryDashboardElement(
+ vm,
+ _vmrepository,
+ new IsolateRepository(vm),
+ editor,
+ _allocationProfileRepository,
+ _heapSnapshotRepository,
+ _objectRepository,
+ app.events,
+ app.notifications,
queue: app.queue)
];
}).catchError((e, stack) {
« no previous file with comments | « no previous file | runtime/observatory/lib/src/elements/css/shared.css » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698