Introduce heap snapshot into Memory Dashboard

Introduce heap snapshot into Memory Dashboard

In the Memory Dashboard, once an isolate is selected, it is now possible
to see the allocation profile or the heap snapshot.

R=asiva@google.com

Committed: https://github.com/dart-lang/sdk/commit/a21eee5c004ddbfc4b586b5d1738b71d724dd896

[cbernaschina, 2017-08-17 15:20:11]

Description was changed from

==========
Introduce heap snapshot into Memory Dashboard

In the Memory Dashboard, once an isolate is selected, it is now possible
to see the allocation profile or the heap snapshot.
==========

to

==========
Introduce heap snapshot into Memory Dashboard

In the Memory Dashboard, once an isolate is selected, it is now possible
to see the allocation profile or the heap snapshot.
==========

[cbernaschina, 2017-08-17 15:20:11]

cbernaschina@google.com changed reviewers:
+ asiva@google.com

[siva, 2017-08-19 00:35:47]

lgtm

https://codereview.chromium.org/3002843002/diff/1/runtime/observatory/lib/src...
File runtime/observatory/lib/src/elements/memory/snapshot.dart (right):

https://codereview.chromium.org/3002843002/diff/1/runtime/observatory/lib/src...
runtime/observatory/lib/src/elements/memory/snapshot.dart:7: // BSD-style
license that can be found in the LICENSE file.
Why two copyright lines here?

https://codereview.chromium.org/3002843002/diff/40001/runtime/observatory/lib...
File runtime/observatory/lib/src/elements/memory/profile.dart (right):

https://codereview.chromium.org/3002843002/diff/40001/runtime/observatory/lib...
runtime/observatory/lib/src/elements/memory/profile.dart:44: _Analysis _analisys
= _Analysis.allocations;
is the typo in name intentional (_analisys instead of _analysis) ?

https://codereview.chromium.org/3002843002/diff/40001/runtime/observatory/lib...
File runtime/observatory/lib/src/elements/memory/snapshot.dart (right):

https://codereview.chromium.org/3002843002/diff/40001/runtime/observatory/lib...
runtime/observatory/lib/src/elements/memory/snapshot.dart:245: //
TODO(cbernaschina) open debugger?
Maybe open an issue and refer to this using the issue number
// TODO (dartbug.com/XXXXX)

[cbernaschina, 2017-08-19 01:03:37]

https://codereview.chromium.org/3002843002/diff/1/runtime/observatory/lib/src...
File runtime/observatory/lib/src/elements/memory/snapshot.dart (right):

https://codereview.chromium.org/3002843002/diff/1/runtime/observatory/lib/src...
runtime/observatory/lib/src/elements/memory/snapshot.dart:7: // BSD-style
license that can be found in the LICENSE file.
On 2017/08/19 00:35:46, siva wrote:
> Why two copyright lines here?

Bad copy&paste.

done

https://codereview.chromium.org/3002843002/diff/40001/runtime/observatory/lib...
File runtime/observatory/lib/src/elements/memory/profile.dart (right):

https://codereview.chromium.org/3002843002/diff/40001/runtime/observatory/lib...
runtime/observatory/lib/src/elements/memory/profile.dart:44: _Analysis _analisys
= _Analysis.allocations;
done

[cbernaschina, 2017-08-19 01:04:52]

Description was changed from

==========
Introduce heap snapshot into Memory Dashboard

In the Memory Dashboard, once an isolate is selected, it is now possible
to see the allocation profile or the heap snapshot.
==========

to

==========
Introduce heap snapshot into Memory Dashboard

In the Memory Dashboard, once an isolate is selected, it is now possible
to see the allocation profile or the heap snapshot.

R=asiva@google.com

Committed:
https://github.com/dart-lang/sdk/commit/a21eee5c004ddbfc4b586b5d1738b71d724dd896
==========

[cbernaschina, 2017-08-19 01:04:54]

Committed patchset #4 (id:60001) manually as
a21eee5c004ddbfc4b586b5d1738b71d724dd896 (presubmit successful).