Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(433)

Unified Diff: runtime/observatory/lib/src/elements/memory/allocations.dart

Issue 3002843002: Introduce heap snapshot into Memory Dashboard (Closed)
Patch Set: Address CL comments Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/observatory/lib/src/elements/memory/allocations.dart
diff --git a/runtime/observatory/lib/src/elements/memory/profile.dart b/runtime/observatory/lib/src/elements/memory/allocations.dart
similarity index 92%
copy from runtime/observatory/lib/src/elements/memory/profile.dart
copy to runtime/observatory/lib/src/elements/memory/allocations.dart
index 2d0e0093f224b73b8b3a9000f03d00fc00ac44b2..b02a81a50d8e97ad9a53e26ff0b3b022055aab09 100644
--- a/runtime/observatory/lib/src/elements/memory/profile.dart
+++ b/runtime/observatory/lib/src/elements/memory/allocations.dart
@@ -32,13 +32,14 @@ enum _SortingField {
enum _SortingDirection { ascending, descending }
-class MemoryProfileElement extends HtmlElement implements Renderable {
- static const tag = const Tag<MemoryProfileElement>('memory-profile',
+class MemoryAllocationsElement extends HtmlElement implements Renderable {
+ static const tag = const Tag<MemoryAllocationsElement>('memory-allocations',
dependencies: const [ClassRefElement.tag, VirtualCollectionElement.tag]);
- RenderingScheduler<MemoryProfileElement> _r;
+ RenderingScheduler<MemoryAllocationsElement> _r;
- Stream<RenderedEvent<MemoryProfileElement>> get onRendered => _r.onRendered;
+ Stream<RenderedEvent<MemoryAllocationsElement>> get onRendered =>
+ _r.onRendered;
M.IsolateRef _isolate;
M.EventRepository _events;
@@ -51,14 +52,17 @@ class MemoryProfileElement extends HtmlElement implements Renderable {
M.IsolateRef get isolate => _isolate;
- factory MemoryProfileElement(M.IsolateRef isolate, M.EditorRepository editor,
- M.EventRepository events, M.AllocationProfileRepository repository,
+ factory MemoryAllocationsElement(
+ M.IsolateRef isolate,
+ M.EditorRepository editor,
+ M.EventRepository events,
+ M.AllocationProfileRepository repository,
{RenderingQueue queue}) {
assert(isolate != null);
assert(events != null);
assert(editor != null);
assert(repository != null);
- MemoryProfileElement e = document.createElement(tag.name);
+ MemoryAllocationsElement e = document.createElement(tag.name);
e._r = new RenderingScheduler(e, queue: queue);
e._isolate = isolate;
e._editor = editor;
@@ -67,7 +71,7 @@ class MemoryProfileElement extends HtmlElement implements Renderable {
return e;
}
- MemoryProfileElement.created() : super.created();
+ MemoryAllocationsElement.created() : super.created();
@override
attached() {
@@ -232,7 +236,7 @@ class MemoryProfileElement extends HtmlElement implements Renderable {
e.children[4] = new ClassRefElement(_isolate, item.clazz, queue: _r.queue)
..classes = ['name'];
Element.clickEvent.forTarget(e.children[4], useCapture: true).listen((e) {
- if (_editor.canOpenClass) {
+ if (_editor.isAvailable) {
e.preventDefault();
_editor.openClass(isolate, item.clazz);
}
« no previous file with comments | « runtime/observatory/lib/src/elements/css/shared.css ('k') | runtime/observatory/lib/src/elements/memory/dashboard.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698