runtime/observatory/lib/src/models/repositories/editor.dart - Issue 3002843002: Introduce heap snapshot into Memory Dashboard

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/observatory/lib/src/models/repositories/editor.dart

Issue 3002843002: Introduce heap snapshot into Memory Dashboard (Closed)

Patch Set: Address CL comments Created 3 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/observatory/lib/src/models/repositories/editor.dart

diff --git a/runtime/observatory/lib/src/models/repositories/editor.dart b/runtime/observatory/lib/src/models/repositories/editor.dart

index 6d6011a995af6f545acabed787ff47aa98de29e0..aef71996f5afdf839410468e6b776764bbb939f4 100644

--- a/runtime/observatory/lib/src/models/repositories/editor.dart

+++ b/runtime/observatory/lib/src/models/repositories/editor.dart

@@ -5,8 +5,11 @@

part of models;

abstract class EditorRepository {

- bool get canOpenClass;

+ bool get isAvailable;

Future openClass(IsolateRef isolate, ClassRef clazz);

+ Future openField(IsolateRef isolate, FieldRef clazz);

+ Future openFunction(IsolateRef isolate, FunctionRef clazz);

+ Future openObject(IsolateRef isolate, ObjectRef clazz);

Future openSourceLocation(IsolateRef isolate, SourceLocation location);

}