Begin writing tests of the runtime checks needed for Dart 2.0 soundness.

Begin writing tests of the runtime checks needed for Dart 2.0 soundness.

The tests in this CL illustrate the major use cases where runtime
checks are required.  They are not exhaustive.  In a later CL I will
copy over some of analyzer's internal unit tests, which are much more
thorough.

So far these tests only pass when tested via analyzer, since analyzer
currently is the only platform that does the necessary analysis to
figure out which checks are needed.  In follow up CLs I will begin
introducing code into front_end to determine which checks are needed,
and to record this information in the kernel representation.

R=danrubel@google.com, sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/247f20b5810baa93efbf6d82efff65074413a585

[Paul Berry, 2017-08-17 21:27:06]

paulberry@google.com changed reviewers:
+ danrubel@google.com, sigmund@google.com

[danrubel, 2017-08-18 12:38:33]

LGTM

[Siggi Cherem (dart-lang), 2017-08-18 18:15:25]

lgtm

[Siggi Cherem (dart-lang), 2017-08-18 18:17:10]

very exciting to see these come together.

Question about the @forwardingStub - how are those going to be checked?

The other annotations seem to map nicely to a runtime check at the same location
of the annotation (and I understand that some can be placed either on the caller
or callee), but i'm less clear about the forwarding ones.

[Paul Berry, 2017-08-21 05:22:57]

On 2017/08/18 18:17:10, Siggi Cherem (dart-lang) wrote:
> very exciting to see these come together.
> 
> Question about the @forwardingStub - how are those going to be checked?
> 
> The other annotations seem to map nicely to a runtime check at the same
location
> of the annotation (and I understand that some can be placed either on the
caller
> or callee), but i'm less clear about the forwarding ones.

The forwarding stubs represent synthetic methods that need to be generated by
the front end and inserted into the kernel representation.  The back end will
just treat them like ordinary methods (unless it knows that they are not needed
due to back end implementation details).

So, for example, in the test
"covariant_generic_parameter_in_interface_super.dart", the annotation:

/*@forwardingStub=void f(semiSafe int x)*/

means that the front end will need to add a synthetic method to class C which
looks like this:

void f(int /*@checkFormal=semiSafe*/ x) => super.f(x);

The check will now happen according to the usual rules for the interpretation of
a "semi-safe" formal parameter.

[Paul Berry, 2017-08-21 05:28:42]

Description was changed from

==========
Begin writing tests of the runtime checks needed for Dart 2.0 soundness.

The tests in this CL illustrate the major use cases where runtime
checks are required.  They are not exhaustive.  In a later CL I will
copy over some of analyzer's internal unit tests, which are much more
thorough.

So far these tests only pass when tested via analyzer, since analyzer
currently is the only platform that does the necessary analysis to
figure out which checks are needed.  In follow up CLs I will begin
introducing code into front_end to determine which checks are needed,
and to record this information in the kernel representation.
==========

to

==========
Begin writing tests of the runtime checks needed for Dart 2.0 soundness.

The tests in this CL illustrate the major use cases where runtime
checks are required.  They are not exhaustive.  In a later CL I will
copy over some of analyzer's internal unit tests, which are much more
thorough.

So far these tests only pass when tested via analyzer, since analyzer
currently is the only platform that does the necessary analysis to
figure out which checks are needed.  In follow up CLs I will begin
introducing code into front_end to determine which checks are needed,
and to record this information in the kernel representation.

R=danrubel@google.com, sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/247f20b5810baa93efbf6d82efff65074413a585
==========

[Paul Berry, 2017-08-21 05:28:43]

Committed patchset #2 (id:20001) manually as
247f20b5810baa93efbf6d82efff65074413a585 (presubmit successful).