Enable installing test CA on Android & add test for it

Enable installing test CA on Android & add test for it

This CL also enable "--ignore-certificate-errors" even if test CA is installed. Later 
work will remove "--ignore-certificate-errors" if test CA is installed to mitigate the risk
of breaking perf waterfall.

BUG=chromium:753948

[nednguyen, 2017-08-18 19:04:42]

Patchset #1 (id:1) has been deleted

[nednguyen, 2017-08-18 19:05:01]

nednguyen@google.com changed reviewers:
+ xunjieli@chromium.org

[nednguyen, 2017-08-18 19:05:56]

Description was changed from

==========
Enable installing test CA on Android & add test for it

BUG=chromium:753948
==========

to

==========
Enable installing test CA on Android & add test for it

This CL also enable "--ignore-certificate-errors" even if test CA is installed.
Later 
work will remove "--ignore-certificate-errors" if test CA is installed to
mitigate the risk
of breaking perf waterfall.

BUG=chromium:753948
==========

[nednguyen, 2017-08-18 19:06:24]

The CQ bit was checked by nednguyen@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-08-18 19:06:37]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-08-18 19:39:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-08-18 19:39:23]

Dry run: Try jobs failed on following builders:
  Catapult Android Tryserver on master.tryserver.client.catapult (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20An...)

[nednguyen, 2017-08-18 19:42:00]

On 2017/08/18 19:05:01, nednguyen wrote:

And.. the added test is failing.

Helen, I think this is probably a bug in wprgo?

  CalledProcessError: Command
'[u'/b/build/slave/Catapult_Android_Tryserver/build/catapult/telemetry/telemetry/internal/bin/linux/x86_64/wpr',
'installroot', '--android_device_id=03852c76003b9c48',
u'--adb_binary_path=/b/build/slave/Catapult_Android_Tryserver/build/catapult/devil/bin/deps/linux2/x86_64/bin/adb']'
returned non-zero exit status 1
Install root failed: failed to write to temp file open
/tmp/adb_install_root215914571: is a directory(INFO) 2017-08-18 12:38:49,821
pid=9167  cmd_helper._ValidateAndLogCommand:160  [host]>
/b/build/slave/Catapult_Android_Tryserver/build/catapult/devil/bin/deps/linux2/x86_64/bin/adb
-s 03852c76003b9c48 shell '( ps | grep -F com.google.android.apps.chrome; echo
"PIPESTATUS: ${PIPESTATUS[@]}" );echo %$?'

[xunjieli, 2017-08-18 20:05:57]

On 2017/08/18 19:42:00, nednguyen wrote:
> On 2017/08/18 19:05:01, nednguyen wrote:
> 
> And.. the added test is failing.
> 
> Helen, I think this is probably a bug in wprgo?
> 
>   CalledProcessError: Command
>
'[u'/b/build/slave/Catapult_Android_Tryserver/build/catapult/telemetry/telemetry/internal/bin/linux/x86_64/wpr',
> 'installroot', '--android_device_id=03852c76003b9c48',
>
u'--adb_binary_path=/b/build/slave/Catapult_Android_Tryserver/build/catapult/devil/bin/deps/linux2/x86_64/bin/adb']'
> returned non-zero exit status 1
> Install root failed: failed to write to temp file open
> /tmp/adb_install_root215914571: is a directory(INFO) 2017-08-18 12:38:49,821
> pid=9167  cmd_helper._ValidateAndLogCommand:160  [host]>
>
/b/build/slave/Catapult_Android_Tryserver/build/catapult/devil/bin/deps/linux2/x86_64/bin/adb
> -s 03852c76003b9c48 shell '( ps | grep -F com.google.android.apps.chrome; echo
> "PIPESTATUS: ${PIPESTATUS[@]}" );echo %$?'

Looks like the openssl command failed, the install root script didn't propagate
the error. I will add the error msg.

[nednguyen, 2017-08-21 16:39:33]

The CQ bit was checked by nednguyen@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-08-21 16:39:37]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-08-21 17:18:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-08-21 17:18:48]

Dry run: Try jobs failed on following builders:
  Catapult Android Tryserver on master.tryserver.client.catapult (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20An...)

[nednguyen, 2017-08-21 20:52:52]

On 2017/08/18 20:05:57, xunjieli wrote:
> On 2017/08/18 19:42:00, nednguyen wrote:
> > On 2017/08/18 19:05:01, nednguyen wrote:
> > 
> > And.. the added test is failing.
> > 
> > Helen, I think this is probably a bug in wprgo?
> > 
> >   CalledProcessError: Command
> >
>
'[u'/b/build/slave/Catapult_Android_Tryserver/build/catapult/telemetry/telemetry/internal/bin/linux/x86_64/wpr',
> > 'installroot', '--android_device_id=03852c76003b9c48',
> >
>
u'--adb_binary_path=/b/build/slave/Catapult_Android_Tryserver/build/catapult/devil/bin/deps/linux2/x86_64/bin/adb']'
> > returned non-zero exit status 1
> > Install root failed: failed to write to temp file open
> > /tmp/adb_install_root215914571: is a directory(INFO) 2017-08-18 12:38:49,821
> > pid=9167  cmd_helper._ValidateAndLogCommand:160  [host]>
> >
>
/b/build/slave/Catapult_Android_Tryserver/build/catapult/devil/bin/deps/linux2/x86_64/bin/adb
> > -s 03852c76003b9c48 shell '( ps | grep -F com.google.android.apps.chrome;
echo
> > "PIPESTATUS: ${PIPESTATUS[@]}" );echo %$?'
> 
> Looks like the openssl command failed, the install root script didn't
propagate
> the error. I will add the error msg.

Now the error message is: 

Install root failed: cannot create issuer hash: exit status 1(INFO) 2017-08-21
10:18:32,789 pid=8287  cmd_helper._ValidateAndLogCommand:160  [host]>
/b/build/slave/Catapult_Android_Tryserver/build/catapult/devil/bin/deps/linux2/x86_64/bin/adb
-s 03852c76003b9c48 shell '( ps | grep -F com.google.android.apps.chrome; echo
"PIPESTATUS: ${PIPESTATUS[@]}" );echo %$?'

[xunjieli, 2017-08-21 21:25:24]

On 2017/08/21 20:52:52, nednguyen wrote:
> On 2017/08/18 20:05:57, xunjieli wrote:
> > On 2017/08/18 19:42:00, nednguyen wrote:
> > > On 2017/08/18 19:05:01, nednguyen wrote:
> > > 
> > > And.. the added test is failing.
> > > 
> > > Helen, I think this is probably a bug in wprgo?
> > > 
> > >   CalledProcessError: Command
> > >
> >
>
'[u'/b/build/slave/Catapult_Android_Tryserver/build/catapult/telemetry/telemetry/internal/bin/linux/x86_64/wpr',
> > > 'installroot', '--android_device_id=03852c76003b9c48',
> > >
> >
>
u'--adb_binary_path=/b/build/slave/Catapult_Android_Tryserver/build/catapult/devil/bin/deps/linux2/x86_64/bin/adb']'
> > > returned non-zero exit status 1
> > > Install root failed: failed to write to temp file open
> > > /tmp/adb_install_root215914571: is a directory(INFO) 2017-08-18
12:38:49,821
> > > pid=9167  cmd_helper._ValidateAndLogCommand:160  [host]>
> > >
> >
>
/b/build/slave/Catapult_Android_Tryserver/build/catapult/devil/bin/deps/linux2/x86_64/bin/adb
> > > -s 03852c76003b9c48 shell '( ps | grep -F com.google.android.apps.chrome;
> echo
> > > "PIPESTATUS: ${PIPESTATUS[@]}" );echo %$?'
> > 
> > Looks like the openssl command failed, the install root script didn't
> propagate
> > the error. I will add the error msg.
> 
> Now the error message is: 
> 
> Install root failed: cannot create issuer hash: exit status 1(INFO) 2017-08-21
> 10:18:32,789 pid=8287  cmd_helper._ValidateAndLogCommand:160  [host]>
>
/b/build/slave/Catapult_Android_Tryserver/build/catapult/devil/bin/deps/linux2/x86_64/bin/adb
> -s 03852c76003b9c48 shell '( ps | grep -F com.google.android.apps.chrome; echo
> "PIPESTATUS: ${PIPESTATUS[@]}" );echo %$?'

The Linux host doesn't have "openssl". Can we install it on that host?

[nednguyen, 2017-08-21 21:31:45]

On 2017/08/21 21:25:24, xunjieli wrote:
> On 2017/08/21 20:52:52, nednguyen wrote:
> > On 2017/08/18 20:05:57, xunjieli wrote:
> > > On 2017/08/18 19:42:00, nednguyen wrote:
> > > > On 2017/08/18 19:05:01, nednguyen wrote:
> > > > 
> > > > And.. the added test is failing.
> > > > 
> > > > Helen, I think this is probably a bug in wprgo?
> > > > 
> > > >   CalledProcessError: Command
> > > >
> > >
> >
>
'[u'/b/build/slave/Catapult_Android_Tryserver/build/catapult/telemetry/telemetry/internal/bin/linux/x86_64/wpr',
> > > > 'installroot', '--android_device_id=03852c76003b9c48',
> > > >
> > >
> >
>
u'--adb_binary_path=/b/build/slave/Catapult_Android_Tryserver/build/catapult/devil/bin/deps/linux2/x86_64/bin/adb']'
> > > > returned non-zero exit status 1
> > > > Install root failed: failed to write to temp file open
> > > > /tmp/adb_install_root215914571: is a directory(INFO) 2017-08-18
> 12:38:49,821
> > > > pid=9167  cmd_helper._ValidateAndLogCommand:160  [host]>
> > > >
> > >
> >
>
/b/build/slave/Catapult_Android_Tryserver/build/catapult/devil/bin/deps/linux2/x86_64/bin/adb
> > > > -s 03852c76003b9c48 shell '( ps | grep -F
com.google.android.apps.chrome;
> > echo
> > > > "PIPESTATUS: ${PIPESTATUS[@]}" );echo %$?'
> > > 
> > > Looks like the openssl command failed, the install root script didn't
> > propagate
> > > the error. I will add the error msg.
> > 
> > Now the error message is: 
> > 
> > Install root failed: cannot create issuer hash: exit status 1(INFO)
2017-08-21
> > 10:18:32,789 pid=8287  cmd_helper._ValidateAndLogCommand:160  [host]>
> >
>
/b/build/slave/Catapult_Android_Tryserver/build/catapult/devil/bin/deps/linux2/x86_64/bin/adb
> > -s 03852c76003b9c48 shell '( ps | grep -F com.google.android.apps.chrome;
echo
> > "PIPESTATUS: ${PIPESTATUS[@]}" );echo %$?'
> 
> The Linux host doesn't have "openssl". Can we install it on that host?

Totally! Lemme file a bug & mark it as blocker for CA test installation bugs.

[nednguyen, 2017-08-21 21:59:31]

On 2017/08/21 21:25:24, xunjieli wrote:
> On 2017/08/21 20:52:52, nednguyen wrote:
> > On 2017/08/18 20:05:57, xunjieli wrote:
> > > On 2017/08/18 19:42:00, nednguyen wrote:
> > > > On 2017/08/18 19:05:01, nednguyen wrote:
> > > > 
> > > > And.. the added test is failing.
> > > > 
> > > > Helen, I think this is probably a bug in wprgo?
> > > > 
> > > >   CalledProcessError: Command
> > > >
> > >
> >
>
'[u'/b/build/slave/Catapult_Android_Tryserver/build/catapult/telemetry/telemetry/internal/bin/linux/x86_64/wpr',
> > > > 'installroot', '--android_device_id=03852c76003b9c48',
> > > >
> > >
> >
>
u'--adb_binary_path=/b/build/slave/Catapult_Android_Tryserver/build/catapult/devil/bin/deps/linux2/x86_64/bin/adb']'
> > > > returned non-zero exit status 1
> > > > Install root failed: failed to write to temp file open
> > > > /tmp/adb_install_root215914571: is a directory(INFO) 2017-08-18
> 12:38:49,821
> > > > pid=9167  cmd_helper._ValidateAndLogCommand:160  [host]>
> > > >
> > >
> >
>
/b/build/slave/Catapult_Android_Tryserver/build/catapult/devil/bin/deps/linux2/x86_64/bin/adb
> > > > -s 03852c76003b9c48 shell '( ps | grep -F
com.google.android.apps.chrome;
> > echo
> > > > "PIPESTATUS: ${PIPESTATUS[@]}" );echo %$?'
> > > 
> > > Looks like the openssl command failed, the install root script didn't
> > propagate
> > > the error. I will add the error msg.
> > 
> > Now the error message is: 
> > 
> > Install root failed: cannot create issuer hash: exit status 1(INFO)
2017-08-21
> > 10:18:32,789 pid=8287  cmd_helper._ValidateAndLogCommand:160  [host]>
> >
>
/b/build/slave/Catapult_Android_Tryserver/build/catapult/devil/bin/deps/linux2/x86_64/bin/adb
> > -s 03852c76003b9c48 shell '( ps | grep -F com.google.android.apps.chrome;
echo
> > "PIPESTATUS: ${PIPESTATUS[@]}" );echo %$?'
> 
> The Linux host doesn't have "openssl". Can we install it on that host? On
another hand, can you modify webpagreplaygo so that it throws "need openssl
installed" right away so that the error message is clearer? :-)

[xunjieli, 2017-08-21 22:43:35]

On 2017/08/21 21:59:31, nednguyen wrote:
> On 2017/08/21 21:25:24, xunjieli wrote:
> > On 2017/08/21 20:52:52, nednguyen wrote:
> > > On 2017/08/18 20:05:57, xunjieli wrote:
> > > > On 2017/08/18 19:42:00, nednguyen wrote:
> > > > > On 2017/08/18 19:05:01, nednguyen wrote:
> > > > > 
> > > > > And.. the added test is failing.
> > > > > 
> > > > > Helen, I think this is probably a bug in wprgo?
> > > > > 
> > > > >   CalledProcessError: Command
> > > > >
> > > >
> > >
> >
>
'[u'/b/build/slave/Catapult_Android_Tryserver/build/catapult/telemetry/telemetry/internal/bin/linux/x86_64/wpr',
> > > > > 'installroot', '--android_device_id=03852c76003b9c48',
> > > > >
> > > >
> > >
> >
>
u'--adb_binary_path=/b/build/slave/Catapult_Android_Tryserver/build/catapult/devil/bin/deps/linux2/x86_64/bin/adb']'
> > > > > returned non-zero exit status 1
> > > > > Install root failed: failed to write to temp file open
> > > > > /tmp/adb_install_root215914571: is a directory(INFO) 2017-08-18
> > 12:38:49,821
> > > > > pid=9167  cmd_helper._ValidateAndLogCommand:160  [host]>
> > > > >
> > > >
> > >
> >
>
/b/build/slave/Catapult_Android_Tryserver/build/catapult/devil/bin/deps/linux2/x86_64/bin/adb
> > > > > -s 03852c76003b9c48 shell '( ps | grep -F
> com.google.android.apps.chrome;
> > > echo
> > > > > "PIPESTATUS: ${PIPESTATUS[@]}" );echo %$?'
> > > > 
> > > > Looks like the openssl command failed, the install root script didn't
> > > propagate
> > > > the error. I will add the error msg.
> > > 
> > > Now the error message is: 
> > > 
> > > Install root failed: cannot create issuer hash: exit status 1(INFO)
> 2017-08-21
> > > 10:18:32,789 pid=8287  cmd_helper._ValidateAndLogCommand:160  [host]>
> > >
> >
>
/b/build/slave/Catapult_Android_Tryserver/build/catapult/devil/bin/deps/linux2/x86_64/bin/adb
> > > -s 03852c76003b9c48 shell '( ps | grep -F com.google.android.apps.chrome;
> echo
> > > "PIPESTATUS: ${PIPESTATUS[@]}" );echo %$?'
> > 
> > The Linux host doesn't have "openssl". Can we install it on that host? On
> another hand, can you modify webpagreplaygo so that it throws "need openssl
> installed" right away so that the error message is clearer? :-)

It prints out the error. I am not sure why it doesn't give a more specific error
in |err|. 

  80         issuerHashFileName, err := getIssuerHashFileName(certPath)
  81         if err != nil {
  82                 return fmt.Errorf("cannot create issuer hash: %v", err)
  83         }

[nednguyen, 2017-08-21 22:55:42]

On 2017/08/21 22:43:35, xunjieli wrote:
> On 2017/08/21 21:59:31, nednguyen wrote:
> > On 2017/08/21 21:25:24, xunjieli wrote:
> > > On 2017/08/21 20:52:52, nednguyen wrote:
> > > > On 2017/08/18 20:05:57, xunjieli wrote:
> > > > > On 2017/08/18 19:42:00, nednguyen wrote:
> > > > > > On 2017/08/18 19:05:01, nednguyen wrote:
> > > > > > 
> > > > > > And.. the added test is failing.
> > > > > > 
> > > > > > Helen, I think this is probably a bug in wprgo?
> > > > > > 
> > > > > >   CalledProcessError: Command
> > > > > >
> > > > >
> > > >
> > >
> >
>
'[u'/b/build/slave/Catapult_Android_Tryserver/build/catapult/telemetry/telemetry/internal/bin/linux/x86_64/wpr',
> > > > > > 'installroot', '--android_device_id=03852c76003b9c48',
> > > > > >
> > > > >
> > > >
> > >
> >
>
u'--adb_binary_path=/b/build/slave/Catapult_Android_Tryserver/build/catapult/devil/bin/deps/linux2/x86_64/bin/adb']'
> > > > > > returned non-zero exit status 1
> > > > > > Install root failed: failed to write to temp file open
> > > > > > /tmp/adb_install_root215914571: is a directory(INFO) 2017-08-18
> > > 12:38:49,821
> > > > > > pid=9167  cmd_helper._ValidateAndLogCommand:160  [host]>
> > > > > >
> > > > >
> > > >
> > >
> >
>
/b/build/slave/Catapult_Android_Tryserver/build/catapult/devil/bin/deps/linux2/x86_64/bin/adb
> > > > > > -s 03852c76003b9c48 shell '( ps | grep -F
> > com.google.android.apps.chrome;
> > > > echo
> > > > > > "PIPESTATUS: ${PIPESTATUS[@]}" );echo %$?'
> > > > > 
> > > > > Looks like the openssl command failed, the install root script didn't
> > > > propagate
> > > > > the error. I will add the error msg.
> > > > 
> > > > Now the error message is: 
> > > > 
> > > > Install root failed: cannot create issuer hash: exit status 1(INFO)
> > 2017-08-21
> > > > 10:18:32,789 pid=8287  cmd_helper._ValidateAndLogCommand:160  [host]>
> > > >
> > >
> >
>
/b/build/slave/Catapult_Android_Tryserver/build/catapult/devil/bin/deps/linux2/x86_64/bin/adb
> > > > -s 03852c76003b9c48 shell '( ps | grep -F
com.google.android.apps.chrome;
> > echo
> > > > "PIPESTATUS: ${PIPESTATUS[@]}" );echo %$?'
> > > 
> > > The Linux host doesn't have "openssl". Can we install it on that host? On
> > another hand, can you modify webpagreplaygo so that it throws "need openssl
> > installed" right away so that the error message is clearer? :-)
> 
> It prints out the error. I am not sure why it doesn't give a more specific
error
> in |err|. 
> 
>   80         issuerHashFileName, err := getIssuerHashFileName(certPath)
>   81         if err != nil {
>   82                 return fmt.Errorf("cannot create issuer hash: %v", err)
>   83         }

Oh, is that because we didn't plumb the stdout command through all the way? The
code in 
https://cs.chromium.org/chromium/src/third_party/catapult/web_page_replay_go/...
probably need to be changed to:

if err != nil {
		return "", err + out.String()
	}

[xunjieli, 2017-08-21 23:00:13]

On 2017/08/21 22:55:42, nednguyen wrote:
> On 2017/08/21 22:43:35, xunjieli wrote:
> > On 2017/08/21 21:59:31, nednguyen wrote:
> > > On 2017/08/21 21:25:24, xunjieli wrote:
> > > > On 2017/08/21 20:52:52, nednguyen wrote:
> > > > > On 2017/08/18 20:05:57, xunjieli wrote:
> > > > > > On 2017/08/18 19:42:00, nednguyen wrote:
> > > > > > > On 2017/08/18 19:05:01, nednguyen wrote:
> > > > > > > 
> > > > > > > And.. the added test is failing.
> > > > > > > 
> > > > > > > Helen, I think this is probably a bug in wprgo?
> > > > > > > 
> > > > > > >   CalledProcessError: Command
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
>
'[u'/b/build/slave/Catapult_Android_Tryserver/build/catapult/telemetry/telemetry/internal/bin/linux/x86_64/wpr',
> > > > > > > 'installroot', '--android_device_id=03852c76003b9c48',
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
>
u'--adb_binary_path=/b/build/slave/Catapult_Android_Tryserver/build/catapult/devil/bin/deps/linux2/x86_64/bin/adb']'
> > > > > > > returned non-zero exit status 1
> > > > > > > Install root failed: failed to write to temp file open
> > > > > > > /tmp/adb_install_root215914571: is a directory(INFO) 2017-08-18
> > > > 12:38:49,821
> > > > > > > pid=9167  cmd_helper._ValidateAndLogCommand:160  [host]>
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
>
/b/build/slave/Catapult_Android_Tryserver/build/catapult/devil/bin/deps/linux2/x86_64/bin/adb
> > > > > > > -s 03852c76003b9c48 shell '( ps | grep -F
> > > com.google.android.apps.chrome;
> > > > > echo
> > > > > > > "PIPESTATUS: ${PIPESTATUS[@]}" );echo %$?'
> > > > > > 
> > > > > > Looks like the openssl command failed, the install root script
didn't
> > > > > propagate
> > > > > > the error. I will add the error msg.
> > > > > 
> > > > > Now the error message is: 
> > > > > 
> > > > > Install root failed: cannot create issuer hash: exit status 1(INFO)
> > > 2017-08-21
> > > > > 10:18:32,789 pid=8287  cmd_helper._ValidateAndLogCommand:160  [host]>
> > > > >
> > > >
> > >
> >
>
/b/build/slave/Catapult_Android_Tryserver/build/catapult/devil/bin/deps/linux2/x86_64/bin/adb
> > > > > -s 03852c76003b9c48 shell '( ps | grep -F
> com.google.android.apps.chrome;
> > > echo
> > > > > "PIPESTATUS: ${PIPESTATUS[@]}" );echo %$?'
> > > > 
> > > > The Linux host doesn't have "openssl". Can we install it on that host?
On
> > > another hand, can you modify webpagreplaygo so that it throws "need
openssl
> > > installed" right away so that the error message is clearer? :-)
> > 
> > It prints out the error. I am not sure why it doesn't give a more specific
> error
> > in |err|. 
> > 
> >   80         issuerHashFileName, err := getIssuerHashFileName(certPath)
> >   81         if err != nil {
> >   82                 return fmt.Errorf("cannot create issuer hash: %v", err)
> >   83         }
> 
> Oh, is that because we didn't plumb the stdout command through all the way?
The
> code in 
>
https://cs.chromium.org/chromium/src/third_party/catapult/web_page_replay_go/...
> probably need to be changed to:
> 
> if err != nil {
> 		return "", err + out.String()
> 	}

The "%v" does print out the string representation of |err|. I am not sure why 
"cannot create issuer hash" is in the output but not the string representation
of |err|.

[nednguyen, 2017-08-21 23:13:56]

On 2017/08/21 23:00:13, xunjieli wrote:
> On 2017/08/21 22:55:42, nednguyen wrote:
> > On 2017/08/21 22:43:35, xunjieli wrote:
> > > On 2017/08/21 21:59:31, nednguyen wrote:
> > > > On 2017/08/21 21:25:24, xunjieli wrote:
> > > > > On 2017/08/21 20:52:52, nednguyen wrote:
> > > > > > On 2017/08/18 20:05:57, xunjieli wrote:
> > > > > > > On 2017/08/18 19:42:00, nednguyen wrote:
> > > > > > > > On 2017/08/18 19:05:01, nednguyen wrote:
> > > > > > > > 
> > > > > > > > And.. the added test is failing.
> > > > > > > > 
> > > > > > > > Helen, I think this is probably a bug in wprgo?
> > > > > > > > 
> > > > > > > >   CalledProcessError: Command
> > > > > > > >
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
>
'[u'/b/build/slave/Catapult_Android_Tryserver/build/catapult/telemetry/telemetry/internal/bin/linux/x86_64/wpr',
> > > > > > > > 'installroot', '--android_device_id=03852c76003b9c48',
> > > > > > > >
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
>
u'--adb_binary_path=/b/build/slave/Catapult_Android_Tryserver/build/catapult/devil/bin/deps/linux2/x86_64/bin/adb']'
> > > > > > > > returned non-zero exit status 1
> > > > > > > > Install root failed: failed to write to temp file open
> > > > > > > > /tmp/adb_install_root215914571: is a directory(INFO) 2017-08-18
> > > > > 12:38:49,821
> > > > > > > > pid=9167  cmd_helper._ValidateAndLogCommand:160  [host]>
> > > > > > > >
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
>
/b/build/slave/Catapult_Android_Tryserver/build/catapult/devil/bin/deps/linux2/x86_64/bin/adb
> > > > > > > > -s 03852c76003b9c48 shell '( ps | grep -F
> > > > com.google.android.apps.chrome;
> > > > > > echo
> > > > > > > > "PIPESTATUS: ${PIPESTATUS[@]}" );echo %$?'
> > > > > > > 
> > > > > > > Looks like the openssl command failed, the install root script
> didn't
> > > > > > propagate
> > > > > > > the error. I will add the error msg.
> > > > > > 
> > > > > > Now the error message is: 
> > > > > > 
> > > > > > Install root failed: cannot create issuer hash: exit status 1(INFO)
> > > > 2017-08-21
> > > > > > 10:18:32,789 pid=8287  cmd_helper._ValidateAndLogCommand:160 
[host]>
> > > > > >
> > > > >
> > > >
> > >
> >
>
/b/build/slave/Catapult_Android_Tryserver/build/catapult/devil/bin/deps/linux2/x86_64/bin/adb
> > > > > > -s 03852c76003b9c48 shell '( ps | grep -F
> > com.google.android.apps.chrome;
> > > > echo
> > > > > > "PIPESTATUS: ${PIPESTATUS[@]}" );echo %$?'
> > > > > 
> > > > > The Linux host doesn't have "openssl". Can we install it on that host?
> On
> > > > another hand, can you modify webpagreplaygo so that it throws "need
> openssl
> > > > installed" right away so that the error message is clearer? :-)
> > > 
> > > It prints out the error. I am not sure why it doesn't give a more specific
> > error
> > > in |err|. 
> > > 
> > >   80         issuerHashFileName, err := getIssuerHashFileName(certPath)
> > >   81         if err != nil {
> > >   82                 return fmt.Errorf("cannot create issuer hash: %v",
err)
> > >   83         }
> > 
> > Oh, is that because we didn't plumb the stdout command through all the way?
> The
> > code in 
> >
>
https://cs.chromium.org/chromium/src/third_party/catapult/web_page_replay_go/...
> > probably need to be changed to:
> > 
> > if err != nil {
> > 		return "", err + out.String()
> > 	}
> 
> The "%v" does print out the string representation of |err|. I am not sure why 
> "cannot create issuer hash" is in the output but not the string representation
> of |err|.

My point here is the |err| from getIssuerHashFileName probably contains only
"returned non-zero exit status 1". To get the actual commandline error message,
we also need to add out.String() to the string message in err (out is
cmd.Stdout), i.e:
if err != nil {
   return "", errors.New(err.Error() + "\n" + out.String())
}

[xunjieli, 2017-08-22 00:21:06]

On 2017/08/21 23:13:56, nednguyen wrote:
> On 2017/08/21 23:00:13, xunjieli wrote:
> > On 2017/08/21 22:55:42, nednguyen wrote:
> > > On 2017/08/21 22:43:35, xunjieli wrote:
> > > > On 2017/08/21 21:59:31, nednguyen wrote:
> > > > > On 2017/08/21 21:25:24, xunjieli wrote:
> > > > > > On 2017/08/21 20:52:52, nednguyen wrote:
> > > > > > > On 2017/08/18 20:05:57, xunjieli wrote:
> > > > > > > > On 2017/08/18 19:42:00, nednguyen wrote:
> > > > > > > > > On 2017/08/18 19:05:01, nednguyen wrote:
> > > > > > > > > 
> > > > > > > > > And.. the added test is failing.
> > > > > > > > > 
> > > > > > > > > Helen, I think this is probably a bug in wprgo?
> > > > > > > > > 
> > > > > > > > >   CalledProcessError: Command
> > > > > > > > >
> > > > > > > >
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
>
'[u'/b/build/slave/Catapult_Android_Tryserver/build/catapult/telemetry/telemetry/internal/bin/linux/x86_64/wpr',
> > > > > > > > > 'installroot', '--android_device_id=03852c76003b9c48',
> > > > > > > > >
> > > > > > > >
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
>
u'--adb_binary_path=/b/build/slave/Catapult_Android_Tryserver/build/catapult/devil/bin/deps/linux2/x86_64/bin/adb']'
> > > > > > > > > returned non-zero exit status 1
> > > > > > > > > Install root failed: failed to write to temp file open
> > > > > > > > > /tmp/adb_install_root215914571: is a directory(INFO)
2017-08-18
> > > > > > 12:38:49,821
> > > > > > > > > pid=9167  cmd_helper._ValidateAndLogCommand:160  [host]>
> > > > > > > > >
> > > > > > > >
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
>
/b/build/slave/Catapult_Android_Tryserver/build/catapult/devil/bin/deps/linux2/x86_64/bin/adb
> > > > > > > > > -s 03852c76003b9c48 shell '( ps | grep -F
> > > > > com.google.android.apps.chrome;
> > > > > > > echo
> > > > > > > > > "PIPESTATUS: ${PIPESTATUS[@]}" );echo %$?'
> > > > > > > > 
> > > > > > > > Looks like the openssl command failed, the install root script
> > didn't
> > > > > > > propagate
> > > > > > > > the error. I will add the error msg.
> > > > > > > 
> > > > > > > Now the error message is: 
> > > > > > > 
> > > > > > > Install root failed: cannot create issuer hash: exit status
1(INFO)
> > > > > 2017-08-21
> > > > > > > 10:18:32,789 pid=8287  cmd_helper._ValidateAndLogCommand:160 
> [host]>
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
>
/b/build/slave/Catapult_Android_Tryserver/build/catapult/devil/bin/deps/linux2/x86_64/bin/adb
> > > > > > > -s 03852c76003b9c48 shell '( ps | grep -F
> > > com.google.android.apps.chrome;
> > > > > echo
> > > > > > > "PIPESTATUS: ${PIPESTATUS[@]}" );echo %$?'
> > > > > > 
> > > > > > The Linux host doesn't have "openssl". Can we install it on that
host?
> > On
> > > > > another hand, can you modify webpagreplaygo so that it throws "need
> > openssl
> > > > > installed" right away so that the error message is clearer? :-)
> > > > 
> > > > It prints out the error. I am not sure why it doesn't give a more
specific
> > > error
> > > > in |err|. 
> > > > 
> > > >   80         issuerHashFileName, err := getIssuerHashFileName(certPath)
> > > >   81         if err != nil {
> > > >   82                 return fmt.Errorf("cannot create issuer hash: %v",
> err)
> > > >   83         }
> > > 
> > > Oh, is that because we didn't plumb the stdout command through all the
way?
> > The
> > > code in 
> > >
> >
>
https://cs.chromium.org/chromium/src/third_party/catapult/web_page_replay_go/...
> > > probably need to be changed to:
> > > 
> > > if err != nil {
> > > 		return "", err + out.String()
> > > 	}
> > 
> > The "%v" does print out the string representation of |err|. I am not sure
why 
> > "cannot create issuer hash" is in the output but not the string
representation
> > of |err|.
> 
> My point here is the |err| from getIssuerHashFileName probably contains only
> "returned non-zero exit status 1". To get the actual commandline error
message,
> we also need to add out.String() to the string message in err (out is
> cmd.Stdout), i.e:
> if err != nil {
>    return "", errors.New(err.Error() + "\n" + out.String())
> }

Hmm.. i somehow mis-read your suggestion. Sorry about that. I uploaded
https://codereview.chromium.org/2997343002/.

[nednguyen, 2017-08-22 12:49:24]

The CQ bit was checked by nednguyen@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-08-22 12:49:28]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-08-22 13:37:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-08-22 13:37:38]

Dry run: Try jobs failed on following builders:
  Catapult Android Tryserver on master.tryserver.client.catapult (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20An...)

[nednguyen, 2017-08-22 13:57:03]

On 2017/08/22 00:21:06, xunjieli wrote:
> On 2017/08/21 23:13:56, nednguyen wrote:
> > On 2017/08/21 23:00:13, xunjieli wrote:
> > > On 2017/08/21 22:55:42, nednguyen wrote:
> > > > On 2017/08/21 22:43:35, xunjieli wrote:
> > > > > On 2017/08/21 21:59:31, nednguyen wrote:
> > > > > > On 2017/08/21 21:25:24, xunjieli wrote:
> > > > > > > On 2017/08/21 20:52:52, nednguyen wrote:
> > > > > > > > On 2017/08/18 20:05:57, xunjieli wrote:
> > > > > > > > > On 2017/08/18 19:42:00, nednguyen wrote:
> > > > > > > > > > On 2017/08/18 19:05:01, nednguyen wrote:
> > > > > > > > > > 
> > > > > > > > > > And.. the added test is failing.
> > > > > > > > > > 
> > > > > > > > > > Helen, I think this is probably a bug in wprgo?
> > > > > > > > > > 
> > > > > > > > > >   CalledProcessError: Command
> > > > > > > > > >
> > > > > > > > >
> > > > > > > >
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
>
'[u'/b/build/slave/Catapult_Android_Tryserver/build/catapult/telemetry/telemetry/internal/bin/linux/x86_64/wpr',
> > > > > > > > > > 'installroot', '--android_device_id=03852c76003b9c48',
> > > > > > > > > >
> > > > > > > > >
> > > > > > > >
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
>
u'--adb_binary_path=/b/build/slave/Catapult_Android_Tryserver/build/catapult/devil/bin/deps/linux2/x86_64/bin/adb']'
> > > > > > > > > > returned non-zero exit status 1
> > > > > > > > > > Install root failed: failed to write to temp file open
> > > > > > > > > > /tmp/adb_install_root215914571: is a directory(INFO)
> 2017-08-18
> > > > > > > 12:38:49,821
> > > > > > > > > > pid=9167  cmd_helper._ValidateAndLogCommand:160  [host]>
> > > > > > > > > >
> > > > > > > > >
> > > > > > > >
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
>
/b/build/slave/Catapult_Android_Tryserver/build/catapult/devil/bin/deps/linux2/x86_64/bin/adb
> > > > > > > > > > -s 03852c76003b9c48 shell '( ps | grep -F
> > > > > > com.google.android.apps.chrome;
> > > > > > > > echo
> > > > > > > > > > "PIPESTATUS: ${PIPESTATUS[@]}" );echo %$?'
> > > > > > > > > 
> > > > > > > > > Looks like the openssl command failed, the install root script
> > > didn't
> > > > > > > > propagate
> > > > > > > > > the error. I will add the error msg.
> > > > > > > > 
> > > > > > > > Now the error message is: 
> > > > > > > > 
> > > > > > > > Install root failed: cannot create issuer hash: exit status
> 1(INFO)
> > > > > > 2017-08-21
> > > > > > > > 10:18:32,789 pid=8287  cmd_helper._ValidateAndLogCommand:160 
> > [host]>
> > > > > > > >
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
>
/b/build/slave/Catapult_Android_Tryserver/build/catapult/devil/bin/deps/linux2/x86_64/bin/adb
> > > > > > > > -s 03852c76003b9c48 shell '( ps | grep -F
> > > > com.google.android.apps.chrome;
> > > > > > echo
> > > > > > > > "PIPESTATUS: ${PIPESTATUS[@]}" );echo %$?'
> > > > > > > 
> > > > > > > The Linux host doesn't have "openssl". Can we install it on that
> host?
> > > On
> > > > > > another hand, can you modify webpagreplaygo so that it throws "need
> > > openssl
> > > > > > installed" right away so that the error message is clearer? :-)
> > > > > 
> > > > > It prints out the error. I am not sure why it doesn't give a more
> specific
> > > > error
> > > > > in |err|. 
> > > > > 
> > > > >   80         issuerHashFileName, err :=
getIssuerHashFileName(certPath)
> > > > >   81         if err != nil {
> > > > >   82                 return fmt.Errorf("cannot create issuer hash:
%v",
> > err)
> > > > >   83         }
> > > > 
> > > > Oh, is that because we didn't plumb the stdout command through all the
> way?
> > > The
> > > > code in 
> > > >
> > >
> >
>
https://cs.chromium.org/chromium/src/third_party/catapult/web_page_replay_go/...
> > > > probably need to be changed to:
> > > > 
> > > > if err != nil {
> > > > 		return "", err + out.String()
> > > > 	}
> > > 
> > > The "%v" does print out the string representation of |err|. I am not sure
> why 
> > > "cannot create issuer hash" is in the output but not the string
> representation
> > > of |err|.
> > 
> > My point here is the |err| from getIssuerHashFileName probably contains only
> > "returned non-zero exit status 1". To get the actual commandline error
> message,
> > we also need to add out.String() to the string message in err (out is
> > cmd.Stdout), i.e:
> > if err != nil {
> >    return "", errors.New(err.Error() + "\n" + out.String())
> > }
> 
> Hmm.. i somehow mis-read your suggestion. Sorry about that. I uploaded
> https://codereview.chromium.org/2997343002/.

Thanks to your other CL, we know have a more detailed error message:

Install root failed: cannot create issuer hash: exit status 1 : Error opening
Certificate wpr_cert.pem
139798684935840:error:02001002:system library:fopen:No such file or
directory:bss_file.c:398:fopen('wpr_cert.pem','r')
139798684935840:error:20074002:BIO routines:FILE_CTRL:system lib:bss_file.c:400:
unable to load certificate

[xunjieli, 2017-08-22 14:09:41]

On 2017/08/22 13:57:03, nednguyen wrote:
> On 2017/08/22 00:21:06, xunjieli wrote:
> > On 2017/08/21 23:13:56, nednguyen wrote:
> > > On 2017/08/21 23:00:13, xunjieli wrote:
> > > > On 2017/08/21 22:55:42, nednguyen wrote:
> > > > > On 2017/08/21 22:43:35, xunjieli wrote:
> > > > > > On 2017/08/21 21:59:31, nednguyen wrote:
> > > > > > > On 2017/08/21 21:25:24, xunjieli wrote:
> > > > > > > > On 2017/08/21 20:52:52, nednguyen wrote:
> > > > > > > > > On 2017/08/18 20:05:57, xunjieli wrote:
> > > > > > > > > > On 2017/08/18 19:42:00, nednguyen wrote:
> > > > > > > > > > > On 2017/08/18 19:05:01, nednguyen wrote:
> > > > > > > > > > > 
> > > > > > > > > > > And.. the added test is failing.
> > > > > > > > > > > 
> > > > > > > > > > > Helen, I think this is probably a bug in wprgo?
> > > > > > > > > > > 
> > > > > > > > > > >   CalledProcessError: Command
> > > > > > > > > > >
> > > > > > > > > >
> > > > > > > > >
> > > > > > > >
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
>
'[u'/b/build/slave/Catapult_Android_Tryserver/build/catapult/telemetry/telemetry/internal/bin/linux/x86_64/wpr',
> > > > > > > > > > > 'installroot', '--android_device_id=03852c76003b9c48',
> > > > > > > > > > >
> > > > > > > > > >
> > > > > > > > >
> > > > > > > >
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
>
u'--adb_binary_path=/b/build/slave/Catapult_Android_Tryserver/build/catapult/devil/bin/deps/linux2/x86_64/bin/adb']'
> > > > > > > > > > > returned non-zero exit status 1
> > > > > > > > > > > Install root failed: failed to write to temp file open
> > > > > > > > > > > /tmp/adb_install_root215914571: is a directory(INFO)
> > 2017-08-18
> > > > > > > > 12:38:49,821
> > > > > > > > > > > pid=9167  cmd_helper._ValidateAndLogCommand:160  [host]>
> > > > > > > > > > >
> > > > > > > > > >
> > > > > > > > >
> > > > > > > >
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
>
/b/build/slave/Catapult_Android_Tryserver/build/catapult/devil/bin/deps/linux2/x86_64/bin/adb
> > > > > > > > > > > -s 03852c76003b9c48 shell '( ps | grep -F
> > > > > > > com.google.android.apps.chrome;
> > > > > > > > > echo
> > > > > > > > > > > "PIPESTATUS: ${PIPESTATUS[@]}" );echo %$?'
> > > > > > > > > > 
> > > > > > > > > > Looks like the openssl command failed, the install root
script
> > > > didn't
> > > > > > > > > propagate
> > > > > > > > > > the error. I will add the error msg.
> > > > > > > > > 
> > > > > > > > > Now the error message is: 
> > > > > > > > > 
> > > > > > > > > Install root failed: cannot create issuer hash: exit status
> > 1(INFO)
> > > > > > > 2017-08-21
> > > > > > > > > 10:18:32,789 pid=8287  cmd_helper._ValidateAndLogCommand:160 
> > > [host]>
> > > > > > > > >
> > > > > > > >
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
>
/b/build/slave/Catapult_Android_Tryserver/build/catapult/devil/bin/deps/linux2/x86_64/bin/adb
> > > > > > > > > -s 03852c76003b9c48 shell '( ps | grep -F
> > > > > com.google.android.apps.chrome;
> > > > > > > echo
> > > > > > > > > "PIPESTATUS: ${PIPESTATUS[@]}" );echo %$?'
> > > > > > > > 
> > > > > > > > The Linux host doesn't have "openssl". Can we install it on that
> > host?
> > > > On
> > > > > > > another hand, can you modify webpagreplaygo so that it throws
"need
> > > > openssl
> > > > > > > installed" right away so that the error message is clearer? :-)
> > > > > > 
> > > > > > It prints out the error. I am not sure why it doesn't give a more
> > specific
> > > > > error
> > > > > > in |err|. 
> > > > > > 
> > > > > >   80         issuerHashFileName, err :=
> getIssuerHashFileName(certPath)
> > > > > >   81         if err != nil {
> > > > > >   82                 return fmt.Errorf("cannot create issuer hash:
> %v",
> > > err)
> > > > > >   83         }
> > > > > 
> > > > > Oh, is that because we didn't plumb the stdout command through all the
> > way?
> > > > The
> > > > > code in 
> > > > >
> > > >
> > >
> >
>
https://cs.chromium.org/chromium/src/third_party/catapult/web_page_replay_go/...
> > > > > probably need to be changed to:
> > > > > 
> > > > > if err != nil {
> > > > > 		return "", err + out.String()
> > > > > 	}
> > > > 
> > > > The "%v" does print out the string representation of |err|. I am not
sure
> > why 
> > > > "cannot create issuer hash" is in the output but not the string
> > representation
> > > > of |err|.
> > > 
> > > My point here is the |err| from getIssuerHashFileName probably contains
only
> > > "returned non-zero exit status 1". To get the actual commandline error
> > message,
> > > we also need to add out.String() to the string message in err (out is
> > > cmd.Stdout), i.e:
> > > if err != nil {
> > >    return "", errors.New(err.Error() + "\n" + out.String())
> > > }
> > 
> > Hmm.. i somehow mis-read your suggestion. Sorry about that. I uploaded
> > https://codereview.chromium.org/2997343002/.
> 
> Thanks to your other CL, we know have a more detailed error message:
> 
> Install root failed: cannot create issuer hash: exit status 1 : Error opening
> Certificate wpr_cert.pem
> 139798684935840:error:02001002:system library:fopen:No such file or
> directory:bss_file.c:398:fopen('wpr_cert.pem','r')
> 139798684935840:error:20074002:BIO routines:FILE_CTRL:system
lib:bss_file.c:400:
> unable to load certificate

ah, great! Can you specify the path to wpr_cert.pem and wpr_key.pem by using
--https_cert_file and --https_key_file? 
It's default to wpr_cert.pem if unspecified.

[nednguyen, 2017-08-22 14:27:17]

The CQ bit was checked by nednguyen@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-08-22 14:27:25]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-08-22 14:58:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-08-22 14:58:35]

Dry run: Try jobs failed on following builders:
  Catapult Android Tryserver on master.tryserver.client.catapult (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20An...)

[nednguyen, 2017-08-22 15:47:02]

Now the failure log get quite interesting. It seems like we fail to increase the
number of certificate in the log

[Omit a lot due to the log limit]

  Traceback (most recent call last):
    File
"/b/build/slave/Catapult_Android_Tryserver/build/catapult/telemetry/telemetry/testing/browser_test_case.py",
line 41, in WrappedMethod
      method(self)
    File
"/b/build/slave/Catapult_Android_Tryserver/build/catapult/telemetry/telemetry/internal/platform/platform_backend_unittest.py",
line 67, in testCAInstallation
      len(self._GetRootCertificates()))
  AssertionError: 158 != 157