Refactor diagnostic spans to share a polymer behavior.

Refactor diagnostic spans to share a polymer behavior.

This facilitates changing how diagnostic spans are built and plumb more
information into them such as DiagnosticMap key (name).

No functional changes.

Review-Url: https://codereview.chromium.org/3002973002
Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/8fc1f77cc8310160be3f66db27c0700f545fec39

[benjhayden, 2017-08-18 17:55:31]

Description was changed from

==========
Refactor diagnostic spans to share a polymer behavior.

This facilitates changing how diagnostic spans are built and plumb more
information into them such as DiagnosticMap key (name) and owning Histogram.

No functional changes.

This is split out of Linkify sample Breakdowns via RelatedHistogramBreakdowns
https://codereview.chromium.org/3001953002
==========

to

==========
Refactor diagnostic spans to share a polymer behavior.

This facilitates changing how diagnostic spans are built and plumb more
information into them such as DiagnosticMap key (name).

No functional changes.

This is split out of Linkify sample Breakdowns via RelatedHistogramBreakdowns
https://codereview.chromium.org/3001953002
==========

[benjhayden, 2017-08-18 17:55:40]

Description was changed from

==========
Refactor diagnostic spans to share a polymer behavior.

This facilitates changing how diagnostic spans are built and plumb more
information into them such as DiagnosticMap key (name).

No functional changes.

This is split out of Linkify sample Breakdowns via RelatedHistogramBreakdowns
https://codereview.chromium.org/3001953002
==========

to

==========
Refactor diagnostic spans to share a polymer behavior.

This facilitates changing how diagnostic spans are built and plumb more
information into them such as DiagnosticMap key (name).

No functional changes.
==========

[benjhayden, 2017-08-18 17:55:51]

Patchset #1 (id:1) has been deleted

[benjhayden, 2017-08-18 17:55:57]

benjhayden@chromium.org changed reviewers:
+ eakuefner@chromium.org

[benjhayden, 2017-08-18 17:55:58]

PTAL

[eakuefner, 2017-08-18 23:24:30]

lgtm

https://codereview.chromium.org/3002973002/diff/20001/tracing/tracing/value/u...
File tracing/tracing/value/ui/diagnostic_span_behavior.html (right):

https://codereview.chromium.org/3002973002/diff/20001/tracing/tracing/value/u...
tracing/tracing/value/ui/diagnostic_span_behavior.html:3: Copyright 2016 The
Chromium Authors. All rights reserved.
2017

[benjhayden, 2017-08-19 04:56:23]

The CQ bit was checked by benjhayden@chromium.org

[commit-bot: I haz the power, 2017-08-19 04:56:33]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-08-19 05:25:27]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1503118583545010,
"parent_rev": "344aee7e135aefe8ed8312dea6191873e00a1931", "commit_rev":
"8fc1f77cc8310160be3f66db27c0700f545fec39"}

[commit-bot: I haz the power, 2017-08-19 05:25:31]

Description was changed from

==========
Refactor diagnostic spans to share a polymer behavior.

This facilitates changing how diagnostic spans are built and plumb more
information into them such as DiagnosticMap key (name).

No functional changes.
==========

to

==========
Refactor diagnostic spans to share a polymer behavior.

This facilitates changing how diagnostic spans are built and plumb more
information into them such as DiagnosticMap key (name).

No functional changes.

Review-Url: https://codereview.chromium.org/3002973002
Committed:
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...
==========

[commit-bot: I haz the power, 2017-08-19 05:25:32]

Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...