devil: Raise DeviceUnreachableError on cmd output "waiting for device"

devil: Raise DeviceUnreachableError on cmd output "waiting for device"

BUG=chromium:748145
Review-Url: https://codereview.chromium.org/3002993002
Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/446ec6522de19e62b6967b257b28c78a1753eb92

[bpastene, 2017-08-19 00:19:35]

bpastene@chromium.org changed reviewers:
+ jbudorick@chromium.org

[jbudorick, 2017-08-19 00:22:13]

lgtm w/ nit

https://codereview.chromium.org/3002993002/diff/1/devil/devil/android/sdk/adb...
File devil/devil/android/sdk/adb_wrapper.py (right):

https://codereview.chromium.org/3002993002/diff/1/devil/devil/android/sdk/adb...
devil/devil/android/sdk/adb_wrapper.py:275: if device_waiting_m is not None or
(not_found_m is not None and
nit: this would be a bit easier to read w/ the line break shuffled around to
match the larger clause break, i.e.

  if (device_waiting_m is not None
      or (not_found_m is not None and not_found_m.group('serial') ==
device_serial)):

[bpastene, 2017-08-19 00:50:31]

https://codereview.chromium.org/3002993002/diff/1/devil/devil/android/sdk/adb...
File devil/devil/android/sdk/adb_wrapper.py (right):

https://codereview.chromium.org/3002993002/diff/1/devil/devil/android/sdk/adb...
devil/devil/android/sdk/adb_wrapper.py:275: if device_waiting_m is not None or
(not_found_m is not None and
On 2017/08/19 00:22:13, jbudorick wrote:
> nit: this would be a bit easier to read w/ the line break shuffled around to
> match the larger clause break, i.e.
> 
>   if (device_waiting_m is not None
>       or (not_found_m is not None and not_found_m.group('serial') ==
> device_serial)):

Done.

[bpastene, 2017-08-19 00:50:37]

The CQ bit was checked by bpastene@chromium.org

[bpastene, 2017-08-19 00:50:38]

The patchset sent to the CQ was uploaded after l-g-t-m from
jbudorick@chromium.org
Link to the patchset: https://codereview.chromium.org/3002993002/#ps20001
(title: "cmnt")

[commit-bot: I haz the power, 2017-08-19 00:50:45]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-08-19 01:17:34]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1503103837886490,
"parent_rev": "d2ffc23f1e05ee72a2fbb6afdd60db51351247e5", "commit_rev":
"446ec6522de19e62b6967b257b28c78a1753eb92"}

[commit-bot: I haz the power, 2017-08-19 01:17:37]

Description was changed from

==========
devil: Raise DeviceUnreachableError on cmd output "waiting for device"

BUG=chromium:748145
==========

to

==========
devil: Raise DeviceUnreachableError on cmd output "waiting for device"

BUG=chromium:748145

Review-Url: https://codereview.chromium.org/3002993002
Committed:
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...
==========

[commit-bot: I haz the power, 2017-08-19 01:17:39]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...