Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 2947843005: Update voice interaction animation (Closed)

Created:
3 years, 6 months ago by xc
Modified:
3 years, 6 months ago
Reviewers:
sky
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Update voice interaction animation Add new tween type SLOW_OUT_LINEAR_IN and use it for the end animation. BUG=b:35624617 TEST=build and flash locally, saw the animation changes Review-Url: https://codereview.chromium.org/2947843005 Cr-Commit-Position: refs/heads/master@{#481608} Committed: https://chromium.googlesource.com/chromium/src/+/591d4f67e37eadf911c0fee80a1d414c9602aaaf

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -19 lines) Patch
M ash/shelf/voice_interaction_overlay.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M ui/gfx/animation/tween.h View 1 chunk +18 lines, -16 lines 1 comment Download
M ui/gfx/animation/tween.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 13 (7 generated)
xc
3 years, 6 months ago (2017-06-21 20:40:10 UTC) #2
xc
https://codereview.chromium.org/2947843005/diff/1/ui/gfx/animation/tween.h File ui/gfx/animation/tween.h (right): https://codereview.chromium.org/2947843005/diff/1/ui/gfx/animation/tween.h#newcode34 ui/gfx/animation/tween.h:34: LINEAR_OUT_SLOW_IN, // Variant of EASE_OUT which should be used ...
3 years, 6 months ago (2017-06-21 20:41:32 UTC) #3
sky
LGTM
3 years, 6 months ago (2017-06-21 20:49:08 UTC) #4
commit-bot: I haz the power
This CL has an open dependency (Issue 2951583002 Patch 100001). Please resolve the dependency and ...
3 years, 6 months ago (2017-06-21 22:15:47 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2947843005/1
3 years, 6 months ago (2017-06-22 17:10:08 UTC) #9
commit-bot: I haz the power
3 years, 6 months ago (2017-06-22 18:19:54 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/591d4f67e37eadf911c0fee80a1d...

Powered by Google App Engine
This is Rietveld 408576698