|
|
DescriptionPolymer: Stop including test related components to production binary.
BUG=None
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2949313002
Cr-Commit-Position: refs/heads/master@{#482334}
Committed: https://chromium.googlesource.com/chromium/src/+/bfbaeb51e23a640bf32e084e34ad6e7e8339e98b
Patch Set 1 : Better approach #Patch Set 2 : Attempt to fix bots. #Patch Set 3 : Fix again. #Patch Set 4 : Rebase #
Depends on Patchset: Messages
Total messages: 30 (22 generated)
Description was changed from ========== Polymer: Stop including test related components to production binary. BUG=None ========== to ========== Polymer: Stop including test related components to production binary. BUG=None CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
The CQ bit was checked by dpapad@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by dpapad@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Patchset #1 (id:1) has been deleted
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by dpapad@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by dpapad@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
@thestig: Do you know how I can include a specific JS file to be evaluated before .cc https://cs.chromium.org/chromium/src/chrome/browser/pdf/pdf_extension_test.cc is executed? I am moving mock_interactions.js file to not be served via a chrome:// URL (because it should not be included in prod binary anyway).
On 2017/06/22 22:26:01, dpapad wrote: > @thestig: Do you know how I can include a specific JS file to be evaluated > before .cc > https://cs.chromium.org/chromium/src/chrome/browser/pdf/pdf_extension_test.cc is > executed? > > I am moving mock_interactions.js file to not be served via a chrome:// URL > (because it should not be included in prod binary anyway). Can you trigger the JS evaluation from C++? Is so, maybe you can do something in SetUpOnMainThread() ?
On 2017/06/22 at 23:20:22, thestig wrote: > On 2017/06/22 22:26:01, dpapad wrote: > > @thestig: Do you know how I can include a specific JS file to be evaluated > > before .cc > > https://cs.chromium.org/chromium/src/chrome/browser/pdf/pdf_extension_test.cc is > > executed? > > > > I am moving mock_interactions.js file to not be served via a chrome:// URL > > (because it should not be included in prod binary anyway). > > Can you trigger the JS evaluation from C++? Is so, maybe you can do something in SetUpOnMainThread() ? Yes. I am doing basically this in a separate CL https://codereview.chromium.org/2949883006. Let's see if the bots agree with me (the tests do pass locally).
The CQ bit was checked by dpapad@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
dpapad@chromium.org changed reviewers: + michaelpg@chromium.org
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by dpapad@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 80001, "attempt_start_ts": 1498497671821570, "parent_rev": "00d432064a6fcd6252211a938840efb8e36b463f", "commit_rev": "bfbaeb51e23a640bf32e084e34ad6e7e8339e98b"}
Message was sent while issue was closed.
Description was changed from ========== Polymer: Stop including test related components to production binary. BUG=None CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== Polymer: Stop including test related components to production binary. BUG=None CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2949313002 Cr-Commit-Position: refs/heads/master@{#482334} Committed: https://chromium.googlesource.com/chromium/src/+/bfbaeb51e23a640bf32e084e34ad... ==========
Message was sent while issue was closed.
Committed patchset #4 (id:80001) as https://chromium.googlesource.com/chromium/src/+/bfbaeb51e23a640bf32e084e34ad...
Message was sent while issue was closed.
On 2017/06/26 at 18:38:51, commit-bot wrote: > Committed patchset #4 (id:80001) as https://chromium.googlesource.com/chromium/src/+/bfbaeb51e23a640bf32e084e34ad... This CL should be pointing to crbug.com/734789. |