runtime/observatory/tests/observatory_ui/inbound_references/element_test.dart - Issue 2995923002: Restore "Speedup Observatory elements first time rendering"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/observatory/tests/observatory_ui/inbound_references/element_test.dart

Issue 2995923002: Restore "Speedup Observatory elements first time rendering" (Closed)

Patch Set: Created 3 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « runtime/observatory/tests/observatory_ui/curly_block/element_test.dart ('k') | runtime/observatory/tests/observatory_ui/objectstore_view/element_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: runtime/observatory/tests/observatory_ui/inbound_references/element_test.dart

diff --git a/runtime/observatory/tests/observatory_ui/inbound_references/element_test.dart b/runtime/observatory/tests/observatory_ui/inbound_references/element_test.dart

index abf04f8f7bd317d524ca406dbdb88bca259bd4a8..5ecf47befad8e64e39cc554ed572612ebaac8751 100644

--- a/runtime/observatory/tests/observatory_ui/inbound_references/element_test.dart

+++ b/runtime/observatory/tests/observatory_ui/inbound_references/element_test.dart

@@ -43,7 +43,7 @@ main() {

document.body.append(e);

await e.onRendered.first;

expect(invoked, isFalse);

- expect(e.children.length, isNonZero, reason: 'has elements');

+ expect(e.children, isNotEmpty, reason: 'has elements');

expect(e.querySelectorAll(iTag).length, isZero);

(e.querySelector(cTag) as CurlyBlockElement).toggle();

await e.onRendered.first;

@@ -52,6 +52,6 @@ main() {

expect(e.querySelectorAll(rTag).length, equals(1));

e.remove();

await e.onRendered.first;

- expect(e.children.length, isZero, reason: 'is empty');

+ expect(e.children, isEmpty, reason: 'is empty');

});

}